Fuchs_Intranet

123 Commits 1 Branch 0 Tags

2 Commits

Include renames

Author	SHA1	Message	Date
StefanandClaude Opus 5.5	d0002ccdad	fix(invoices): send invoice amounts as exact cent-rounded decimals Playwright Tests / test (push) Canceled after 0s Details Stornorechnung saves still failed: the VAT amount was formatted invariantly ("-615.3757999999999") and re-parsed under the server's de-DE culture as -6153757999999999, overflowing numeric(10,3) in fds__setInvoice. - FdsInvoiceData.BuildInvoiceParams: amount params are decimal(10,x) via AmountParam/ParseAmount (culture-independent, rounded to cents); amounts beyond +/-9,999,999.99 throw InvoiceAmountOutOfRangeException. - InvoiceService.RegisterInvoiceAsync: refuses such an invoice with a logged error (EventId InvoiceAmountRejected) instead of storing a wrong amount. - Invoice editor: vat_val is cent-rounded decimal, no float noise. - Tests: InvoiceAmountParamTests replaces the float-based Storno test. - Bump Azure.Storage.Blobs 12.30.0; OCORE/OCORE_web submodules (AngleSharp 1.8.3, Azure.Storage.Files.Shares 12.28.0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-01 10:57:41 +02:00
StefanandClaude Opus 4.8	0a8384ab33	fix(invoices): Stornorechnung save failed on negative totals Customer log: /do/inv/dsave failed with "Error converting data type float to numeric" followed by "Cannot insert the value NULL into column 'InvId'". - Bump OCORE: SQL_Float/SQL_Decimal string overloads parsed negatives via the de-DE server culture ("-19.95" -> -1995); float noise overflowed numeric(10,3), so fds__setInvoice never ran. - InvoiceService: the header save batch now stops with a clear THROW when fds__createInvoice/fds__setInvoice yields no @Id, instead of failing again in fds__createInvoice_Details and burying the real error. Batch SQL extracted to BuildRegisterInvoiceSql for testing. - Tests: signed/culture parsing under de-DE, Storno param build against the proc numeric limits, and the batch guard ordering. - hlp: read-only script to find invoice/reminder amounts stored scaled up by the bug. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-10-01 10:07:13 +02:00

Author

SHA1

Message

Date

StefanandClaude Opus 5.5

d0002ccdad

fix(invoices): send invoice amounts as exact cent-rounded decimals

Playwright Tests / test (push) Canceled after 0s

Details

Stornorechnung saves still failed: the VAT amount was formatted invariantly
("-615.3757999999999") and re-parsed under the server's de-DE culture as
-6153757999999999, overflowing numeric(10,3) in fds__setInvoice.

- FdsInvoiceData.BuildInvoiceParams: amount params are decimal(10,x) via
  AmountParam/ParseAmount (culture-independent, rounded to cents); amounts
  beyond +/-9,999,999.99 throw InvoiceAmountOutOfRangeException.
- InvoiceService.RegisterInvoiceAsync: refuses such an invoice with a logged
  error (EventId InvoiceAmountRejected) instead of storing a wrong amount.
- Invoice editor: vat_val is cent-rounded decimal, no float noise.
- Tests: InvoiceAmountParamTests replaces the float-based Storno test.
- Bump Azure.Storage.Blobs 12.30.0; OCORE/OCORE_web submodules (AngleSharp
  1.8.3, Azure.Storage.Files.Shares 12.28.0).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-01 10:57:41 +02:00

StefanandClaude Opus 4.8

0a8384ab33

fix(invoices): Stornorechnung save failed on negative totals

Customer log: /do/inv/dsave failed with "Error converting data type float to
numeric" followed by "Cannot insert the value NULL into column 'InvId'".

- Bump OCORE: SQL_Float/SQL_Decimal string overloads parsed negatives via the
  de-DE server culture ("-19.95" -> -1995); float noise overflowed
  numeric(10,3), so fds__setInvoice never ran.
- InvoiceService: the header save batch now stops with a clear THROW when
  fds__createInvoice/fds__setInvoice yields no @Id, instead of failing again
  in fds__createInvoice_Details and burying the real error. Batch SQL
  extracted to BuildRegisterInvoiceSql for testing.
- Tests: signed/culture parsing under de-DE, Storno param build against the
  proc numeric limits, and the batch guard ordering.
- hlp: read-only script to find invoice/reminder amounts stored scaled up
  by the bug.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-10-01 10:07:13 +02:00