Enhance banking transaction data structure and validation
Playwright Tests / test (push) Has been cancelled

- Increased the length of the NameOfPayer field from NVARCHAR(60) to NVARCHAR(140) in the banking transactions function, table, temporary table, and user-defined type to accommodate longer names.
- Expanded the SepaRemittanceInformation field from VARCHAR(150) to VARCHAR(200) in the banking transactions function for more detailed remittance information.
- Modified the stored procedure fds__setBankingtransaction_done to return additional transaction data (ValueDate and Amount) along with the success flag for improved notification messaging.
- Added validation in MFRClientConfig constructor to ensure the provided URL is not null or empty, enhancing error handling for configuration settings.
This commit is contained in:
Stefan
2026-07-04 16:37:23 +02:00
parent aaf062fd77
commit c98be7b23f
24 changed files with 287 additions and 74 deletions
@@ -18,8 +18,8 @@ RETURNS @bankingtransactions TABLE
,[ValueDate] date
,[Amount] numeric(9,2)
,[AccountNumberOfPayer] varchar(30)
,[NameOfPayer] nvarchar(60)
,[SepaRemittanceInformation] varchar(150)
,[NameOfPayer] nvarchar(140)
,[SepaRemittanceInformation] varchar(200)
,[EndToEndReference] varchar(50)
,[manu] bit
,[InvId] varchar(15)
@@ -34,7 +34,12 @@ BEGIN
;
--output to confirm as boolean
SELECT CAST( (CASE WHEN ISNULL((SELECT TOP(1) [done_manually] FROM @out), '') <> '' THEN 1 ELSE 0 END) as bit);
--output to confirm as boolean, plus the transaction data needed for the notification message
SELECT
CAST( (CASE WHEN ISNULL((SELECT TOP(1) [done_manually] FROM @out), '') <> '' THEN 1 ELSE 0 END) as bit) as [success]
,b.[ValueDate]
,b.[Amount]
FROM (SELECT 1 as [dummy]) as d
LEFT JOIN [dbo].[fds__bankingtransactions] as b ON b.[taID] = @taID;
END
@@ -13,7 +13,7 @@
[EndToEndReference] VARCHAR (50) NULL,
[JournalNumber] VARCHAR (10) NULL,
[MandateReference] VARCHAR (50) NULL,
[NameOfPayer] NVARCHAR (60) NULL,
[NameOfPayer] NVARCHAR (140) NULL,
[OriginalAmount] VARCHAR (150) NULL,
[OriginatorsIdentificationCode] VARCHAR (150) NULL,
[PayersReferenceParty] VARCHAR (150) NULL,
@@ -14,7 +14,7 @@
[EndToEndReference] VARCHAR (50) NULL,
[JournalNumber] VARCHAR (10) NULL,
[MandateReference] VARCHAR (50) NULL,
[NameOfPayer] NVARCHAR (60) NULL,
[NameOfPayer] NVARCHAR (140) NULL,
[OriginalAmount] VARCHAR (150) NULL,
[OriginatorsIdentificationCode] VARCHAR (150) NULL,
[PayersReferenceParty] VARCHAR (150) NULL,
@@ -12,7 +12,7 @@
[EndToEndReference] VARCHAR (50) NULL,
[JournalNumber] VARCHAR (10) NULL,
[MandateReference] VARCHAR (50) NULL,
[NameOfPayer] NVARCHAR (60) NULL,
[NameOfPayer] NVARCHAR (140) NULL,
[OriginalAmount] VARCHAR (150) NULL,
[OriginatorsIdentificationCode] VARCHAR (150) NULL,
[PayersReferenceParty] VARCHAR (150) NULL,