added improvements on set proces and minor other improvements

This commit is contained in:
Stefan
2026-07-13 22:40:08 +02:00
parent 5c0fdc6c1d
commit 5f85b75c22
55 changed files with 1170 additions and 357 deletions
+1 -1
View File
@@ -10,7 +10,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.7.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.v3" Version="3.2.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
+6 -3
View File
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Linq;
using Fuchs.intranet;
@@ -31,8 +31,11 @@ public class InvoiceOptionsTests
=> Assert.Equal("", InvoiceOptionsFor(new { type = "r" }));
[Fact]
public void DefaultSetPrice_OmitsToken()
=> Assert.Equal("", InvoiceOptionsFor(new { type = "r", setmode = "setprice" }));
public void ExplicitDefaultSetPrice_EmitsToken()
// An explicit choice of the default mode must still be persisted — otherwise it is
// indistinguishable from an invoice that was never switched to set-pricing at all
// (the editor relies on this to hide the "Set-Preisanzeige" menu entry once chosen).
=> Assert.Equal("setmode:setprice", InvoiceOptionsFor(new { type = "r", setmode = "setprice" }));
[Theory]
[InlineData("itemprices", "setmode:itemprices")]
+8 -8
View File
@@ -141,7 +141,7 @@ public class ProcessWebComServiceTests
Assert.True(result);
Assert.Equal(1, handler.CallCount);
var json = JObject.Parse(handler.LastRequestBody!);
Assert.Equal("dev-inbox@example.test", json["recipient"]!.ToString());
Assert.Equal("dev-inbox@example.test", json["communication"]!["to"]!.ToString());
}
[Fact]
@@ -153,7 +153,7 @@ public class ProcessWebComServiceTests
await svc.SendEmailAsync("inv_ov2", "Rechnung 123", "<p>hi</p>", "realcustomer@example.de", "Kunde");
var json = JObject.Parse(handler.LastRequestBody!);
string subject = json["subject"]!.ToString();
string subject = json["communication"]!["subject"]!.ToString();
Assert.Contains("realcustomer@example.de", subject);
Assert.Contains("Rechnung 123", subject);
}
@@ -169,7 +169,7 @@ public class ProcessWebComServiceTests
Assert.True(result);
Assert.Equal(1, handler.CallCount);
var json = JObject.Parse(handler.LastRequestBody!);
Assert.Equal("dev-inbox@example.test", json["recipient"]!.ToString());
Assert.Equal("dev-inbox@example.test", json["communication"]!["to"]!.ToString());
}
[Fact]
@@ -181,7 +181,7 @@ public class ProcessWebComServiceTests
await svc.SendEmailAsync("inv_ov4", "Subject", "<p>hi</p>", "realcustomer@example.de", "Kunde");
var json = JObject.Parse(handler.LastRequestBody!);
Assert.Equal("realcustomer@example.de", json["recipient"]!.ToString());
Assert.Equal("realcustomer@example.de", json["communication"]!["to"]!.ToString());
}
// ── Override enforcement across every real appsettings*.json environment ───
@@ -194,9 +194,9 @@ public class ProcessWebComServiceTests
// hand-typed literal - so a future edit that silently breaks the override key
// or its value in any appsettings*.json file would fail this test.
//
// Note: this API has a single "recipient" field - there is no distinct
// Note: this API has a single "communication.to" field - there is no distinct
// to/cc/bcc concept anywhere in the codebase (see ProcessWebComService.
// SendEmailAsync / payload.recipient). "to/cc/bcc cleared" is therefore fully
// SendEmailAsync / communication.to). "to/cc/bcc cleared" is therefore fully
// satisfied by asserting that field no longer carries the original recipient
// once an override is configured.
public static IEnumerable<object[]> AppSettingsEnvironments()
@@ -236,7 +236,7 @@ public class ProcessWebComServiceTests
Assert.True(result);
Assert.Equal(1, handler.CallCount);
var json = JObject.Parse(handler.LastRequestBody!);
string sentRecipient = json["recipient"]!.ToString();
string sentRecipient = json["communication"]!["to"]!.ToString();
if (!string.IsNullOrWhiteSpace(overrideRecipient))
{
@@ -266,7 +266,7 @@ public class ProcessWebComServiceTests
Assert.True(result);
Assert.NotNull(handler.LastRequestBody);
var json = JObject.Parse(handler.LastRequestBody!);
var att = (JArray)json["attachments"]!;
var att = (JArray)json["communication"]!["attachments"]!;
Assert.Single(att);
Assert.Equal("Rechnung.pdf", att[0]!["filename"]!.ToString());
Assert.Equal("application/pdf", att[0]!["mimeType"]!.ToString());