Stefan/Fuchs_Intranet
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Let admins create and delete users in Benutzerverwaltung, modernize list
Playwright Tests / test (push) Canceled after 0s
Details

Browse Source 
Wire up two previously-unwired stored procedures for the usr module:
- fis_admin_createUserAccount gained the missing @authaccount +
  intranet_admin auth gate, a duplicate-email check, and now returns
  the (possibly auto-generated) password so it can be emailed to the
  new user, mirroring fis_admin_resetUserPassword's pattern.
- fis_admin_delUserAccount gained the same missing auth gate plus a
  guard against an admin deleting their own account.

New /do/usr/create and /do/usr/delete endpoints in
IntranetController.AdminUsers.cs, a "Neuer Benutzer" button and a
"Benutzer löschen" ribbon action in fis.usr.js, and unit tests for the
new welcome-email content (BuildWelcomeEmail).

Also restyle the user list (fis.usr.scss) from a plain bordered table
to a card-style row grid with avatar-initial badges and status pills,
matching the Admin dashboard's visual language.

Documented as ADR 0020 and in the admin-user-management concept doc.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Stefan
2026-09-14 14:51:59 +02:00
co-authored by Claude Sonnet 5
parent 38145a917e
commit 4386a6336a
14 changed files with 716 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Fuchs/js/intranet/modules/fis.usr.js
+68 -14
View File
@@ -12,7 +12,7 @@ let $usr = {
},
/* Default ribbon (nothing selected). */
eM: function (r) {
let m = [];
let m = [{ lbl: $uct.newuser_btn, fnc: $usr.createDlg }];
if (bool(r, false) === true) { m.push({ lbl: $uct.rel, fnc: $usr.renderLst }); }
return $('#topbar').ocmsmenu(m);
},
@@ -21,28 +21,43 @@ let $usr = {
return $('#topbar').ocmsmenu([
{ lbl: $uct.pwdreset, fnc: function () { $usr.pwdResetDlg(rw); } },
{ lbl: $uct.email, fnc: function () { $usr.emailDlg(rw); } },
{ lbl: $uct.groups, fnc: function () { $usr.groupsDlg(rw); } }
{ lbl: $uct.groups, fnc: function () { $usr.groupsDlg(rw); } },
{ lbl: $uct.delete, fnc: function () { $usr.deleteUser(rw); } }
]);
},
/* initials for the avatar badge, e.g. "Nadine Beckmann" -> "NB" */
initials: function (firstname, name) {
let f = (firstname || '').trim().charAt(0), n = (name || '').trim().charAt(0);
return (f + n).toUpperCase() || '?';
},
renderLst: function () {
let usrlst = $fis.frm_list(true, true).ldng(1), usrfrm = $$.dc('usrfrm', usrlst);
$usr.eM(true);
$ocms.postXT({
url: $ocms.url('usr/list'), success: function (r) {
usrfrm.empty();
let ts = $$.tblset({}, usrfrm);
let thr = $$.tr(ts.hd);
$.each([$uct.col_name, $uct.col_email, $uct.col_status], function (i, lbl) {
$$.th(thr).text(lbl);
});
let grid = $$.dc('usr_grid', usrfrm);
let hdr = $$.dc('usr_row usr_row_hd', grid);
$$.dc('usr_col_avatar', hdr);
$$.dc('usr_col_name', hdr).text($uct.col_name);
$$.dc('usr_col_email', hdr).text($uct.col_email);
$$.dc('usr_col_status', hdr).text($uct.col_status);
if ((r.users || []).length === 0) {
$$.dc('usr_empty', grid).text($uct.empty);
return;
}
$.each(r.users || [], function (ri, rw) {
let tr = $$.tr(ts.bdy, { id: 'usr' + rw.useraccount_id });
$$.td(tr).text(`${rw.firstname || ''} ${rw.name || ''}`.trim());
$$.td(tr).text(rw.email || '');
$$.td(tr).text(bool(rw.disabled, false) === true ? $uct.disabled : $uct.active);
tr.click(function () {
tr.toggleClass('selected').siblings().rC('selected');
if (tr.is('.selected') === true) { $usr.iMn(rw); } else { $usr.eM(true); }
let disabled = bool(rw.disabled, false) === true;
let row = $$.dc('usr_row', grid, { id: 'usr' + rw.useraccount_id });
$$.dc('usr_avatar', row).text($usr.initials(rw.firstname, rw.name));
$$.dc('usr_col_name', row).text(`${rw.firstname || ''} ${rw.name || ''}`.trim());
$$.dc('usr_col_email', row).text(rw.email || '');
$$.dc('usr_col_status', row).append(
$$.dc(disabled ? 'usr_pill usr_pill_off' : 'usr_pill usr_pill_on').text(disabled ? $uct.disabled : $uct.active)
);
row.click(function () {
row.toggleClass('selected').siblings().rC('selected');
if (row.is('.selected') === true) { $usr.iMn(rw); } else { $usr.eM(true); }
});
});
}, error: function () {
@@ -51,6 +66,45 @@ let $usr = {
}, complete: function () { usrlst.ldng(0); }
});
},
createDlg: function () {
$ocms.dlgform([
{ name: 'firstname', label: $uct.firstname_field, type: 'string', required: true },
{ name: 'name', label: $uct.name_field, type: 'string', required: true },
{ name: 'email', label: $uct.email_field, type: 'email', required: true },
{ name: 'title', label: $uct.title_field, type: 'string' },
{ name: 'gender', label: $uct.gender_field, type: 'select', url: [['', ''], ['m', $uct.gender_m], ['f', $uct.gender_f]] },
{ name: 'mobile', label: $uct.mobile_field, type: 'string' }
], {
title: $uct.newuser,
button: $uct.newuser_btn,
submit: function (e) {
let c = $(this).ldng(1);
let qs = c.serializeObject(true, { typedvalues: true });
$ocms.postXT({
url: $ocms.url('usr/create'), data: qs, success: function (response) {
alert(response.emailed === true ? $uct.create_sent : $uct.create_noemail);
c.trigger('modal_close');
}, error: function (jqXHR) {
let code = ((jqXHR || {}).responseJSON || {}).error;
alert($uct.err[code] || $uct.err_generic);
}, complete: function () { c.ldng(0); $usr.renderLst(); }
});
}
});
},
deleteUser: function (rw) {
let displayName = `${rw.firstname || ''} ${rw.name || ''}`.trim();
if (confirm(string($uct.delete_confirm, [displayName]))) {
$ocms.postXT({
url: $ocms.url('usr/delete'), data: { useraccount_id: rw.useraccount_id }, success: function () {
$usr.eM(true);
}, error: function (jqXHR) {
let code = ((jqXHR || {}).responseJSON || {}).error;
alert($uct.err[code] || $uct.err_generic);
}, complete: function () { $usr.renderLst(); }
});
}
},
pwdResetDlg: function (rw) {
$ocms.dlgform([
{ name: 'useraccount_id', type: 'hidden', value: rw.useraccount_id },